Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffs trashbags #3817

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Buffs trashbags #3817

merged 2 commits into from
Jul 19, 2023

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Jul 5, 2023 •
edited
Loading

About the pull request

  • Trashbags can now be looked through like boxes
  • Trashbags now fit normal-sized items
  • Trashbags no longer fit as a belt
  • Trashbags have the same storage limits as a backpack

Explain why it's good for the game

  • If you accidentally put something in the bag, the only way to get it out is by dumping it into disposals, which is bad UX
  • This might be me coping, but holy hell is it annoying to not be able to put still-small things like grenade packets and shoes in a trashbag to throw away
  • It occurred to me that marines might take the bag as a belt with these changes, to be a better G8 pouch, so I removed the ability to do that. This should not affect the primary users of trashbags (WJs) because they aren't allowed to remove their toolbelts in the first place
  • This makes trashbags worse backpacks, which morrow was alright with

Testing Photographs and Procedure

Screenshots & Videos image

Changelog

🆑
balance: Trashbags now hold normal items and can be looked through like a box or storage container.
balance: Trashbags no longer fit in your belt slot.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 5, 2023
morrowwolf
morrowwolf reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a balance nightmare.

If it can fit in your hand people will bring it and use it as extended storage and this can hold a ton and easily.

The reason we have the requirement to only remove stuff by putting it in a trashcan is to avoid people using it as storage. Either make it so only Working Joes can take stuff out or reduce the size dramatically (which would include not allowing medium items).

@morrowwolf morrowwolf marked this pull request as draft July 11, 2023 04:09
@Zonespace27 Zonespace27 marked this pull request as ready for review July 17, 2023 10:15
@morrowwolf morrowwolf added this pull request to the merge queue Jul 19, 2023
Merged via the queue into cmss13-devs:master with commit 5600768 Jul 19, 2023
cm13-github added a commit that referenced this pull request Jul 19, 2023
@cm13-github
Automatic changelog for PR #3817 [ci skip]
3085da0
github-actions bot added a commit that referenced this pull request Jul 19, 2023
@github-actions
Updating GBP balances for #3817
24c9864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrowwolf morrowwolf Awaiting requested review from morrowwolf

Assignees
No one assigned
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zonespace27 @morrowwolf @johndoe2013